Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1995863002: Improve strictness of Annex B 3.3 for generators and async functions (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 6 months ago
Reviewers:
adamk
CC:
caitp (gmail), Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Improve strictness of Annex B 3.3 for generators and async functions Annex B 3.3 applies only for ordinary FunctionDeclarations, not GeneratorDeclarations or AsyncFunctionDeclarations. This patch - Skips applying Annex B 3.3 to async functions - Adds a flag to refrain from applying it to generators - UseCounter for how often duplicate function in block occurs with generators (unclear how to measure need for hoisting from block) BUG=v8:4806 Committed: https://crrev.com/6390282f9654dcefe1d2123298b50db9ad5ce1f6 Cr-Commit-Position: refs/heads/master@{#36557}

Patch Set 1 #

Patch Set 2 : style fix #

Patch Set 3 : fix cast #

Patch Set 4 : Use the right function map #

Patch Set 5 : fix mixed duplicates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -3 lines) Patch
M src/bootstrapper.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 4 3 chunks +22 lines, -1 line 0 comments Download
M src/parsing/parser-base.h View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 chunks +61 lines, -1 line 0 comments Download
A test/mjsunit/harmony/sloppy-legacy-duplicate-generators.js View 1 chunk +60 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/sloppy-no-duplicate-async.js View 1 chunk +30 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/sloppy-no-duplicate-generators.js View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995863002/1
4 years, 7 months ago (2016-05-19 00:11:58 UTC) #2
Dan Ehrenberg
4 years, 7 months ago (2016-05-19 00:12:13 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15490)
4 years, 7 months ago (2016-05-19 00:15:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995863002/10001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995863002/10001
4 years, 7 months ago (2016-05-19 00:20:48 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/1843) v8_linux_arm64_rel_ng on ...
4 years, 7 months ago (2016-05-19 00:22:59 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995863002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995863002/30001
4 years, 7 months ago (2016-05-19 01:26:12 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/1815) v8_linux_arm_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-19 01:31:55 UTC) #14
adamk
Looks like you've got some test failures? Ping back when those are resolved, please.
4 years, 7 months ago (2016-05-20 20:49:11 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995863002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995863002/50001
4 years, 6 months ago (2016-05-27 16:46:38 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/2323) v8_linux64_asan_rel_ng_triggered on ...
4 years, 6 months ago (2016-05-27 17:03:20 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995863002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995863002/70001
4 years, 6 months ago (2016-05-27 17:42:29 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 18:05:58 UTC) #23
Dan Ehrenberg
The bugs are fixed. PTAL.
4 years, 6 months ago (2016-05-27 18:08:52 UTC) #24
adamk
lgtm
4 years, 6 months ago (2016-05-27 18:18:12 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995863002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995863002/70001
4 years, 6 months ago (2016-05-27 18:20:28 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:70001)
4 years, 6 months ago (2016-05-27 18:22:39 UTC) #28
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 18:23:27 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6390282f9654dcefe1d2123298b50db9ad5ce1f6
Cr-Commit-Position: refs/heads/master@{#36557}

Powered by Google App Engine
This is Rietveld 408576698