Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1995853002: Remove ApplicationRunner::{Get,Set}DefaultLogger(). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove ApplicationRunner::{Get,Set}DefaultLogger(). They don't really offer anything over Environment::{Get,Set}DefaultLogger(). Moreover, Environment is a more universal API (i.e., its static functions are "always" available), whereas ApplicationRunner isn't canonical (e.g., there's also ApplicationRunnerChromium). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1c3e36c6ab9e7040f6e54fa05198d99e42654abf

Patch Set 1 #

Patch Set 2 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M mojo/public/cpp/application/application_runner.h View 1 2 chunks +0 lines, -9 lines 0 comments Download
M mojo/public/cpp/application/lib/application_runner.cc View 1 2 chunks +0 lines, -13 lines 0 comments Download
M mojo/services/log/cpp/log_client.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-18 23:37:34 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-19 01:03:30 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-19 16:56:46 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1c3e36c6ab9e7040f6e54fa05198d99e42654abf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698