Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 199583008: Enable Arm64 target arch in gyp build config (Closed)

Created:
6 years, 9 months ago by rmcilroy
Modified:
6 years, 9 months ago
Reviewers:
Nico, Jói
CC:
chromium-reviews, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable Arm64 target arch in gyp build config Initial support to get us started. There is a lot more work to do before we can compile for arm64. BUG=354405 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258363

Patch Set 1 #

Patch Set 2 : Fix a couple of other issues #

Patch Set 3 : Make nacl_defines an empty list on android like ios since it's always disabled' #

Patch Set 4 : Fix typo #

Patch Set 5 : Remove gold #

Total comments: 5

Patch Set 6 : Add todo #

Patch Set 7 : Really add todo... #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : Fix skia.gyp too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
M build/build_config.h View 1 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 3 4 6 chunks +28 lines, -3 lines 0 comments Download
M build/java_apk.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/nacl_defines.gypi View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M skia/skia.gyp View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -2 lines 0 comments Download
M skia/skia_library_opts.gyp View 1 2 3 4 5 6 7 8 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
rmcilroy
joi@chromium.org: Please review changes in components/nacl
6 years, 9 months ago (2014-03-20 14:55:15 UTC) #1
Nico
Please add "BUG=354405" https://codereview.chromium.org/199583008/diff/70001/build/build_config.h File build/build_config.h (right): https://codereview.chromium.org/199583008/diff/70001/build/build_config.h#newcode110 build/build_config.h:110: #elif defined(__arm64__) || defined(__aarch64__) (Ross tells ...
6 years, 9 months ago (2014-03-20 15:00:19 UTC) #2
Nico
Oh, and lgtm with that.
6 years, 9 months ago (2014-03-20 15:00:27 UTC) #3
Jói
//components LGTM
6 years, 9 months ago (2014-03-20 15:00:46 UTC) #4
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 9 months ago (2014-03-20 15:13:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/199583008/120001
6 years, 9 months ago (2014-03-20 15:13:18 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 15:14:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-20 15:14:52 UTC) #8
rmcilroy
Thanks for the reviews all! https://codereview.chromium.org/199583008/diff/70001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/199583008/diff/70001/build/common.gypi#newcode3411 build/common.gypi:3411: ['_toolset=="target"', { On 2014/03/20 ...
6 years, 9 months ago (2014-03-20 15:14:53 UTC) #9
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 9 months ago (2014-03-20 15:33:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/199583008/140001
6 years, 9 months ago (2014-03-20 15:34:12 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 15:37:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-20 15:37:47 UTC) #13
rmcilroy
The CQ bit was unchecked by rmcilroy@chromium.org
6 years, 9 months ago (2014-03-20 15:41:03 UTC) #14
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 9 months ago (2014-03-20 15:48:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/199583008/160001
6 years, 9 months ago (2014-03-20 15:49:09 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 18:35:54 UTC) #17
Message was sent while issue was closed.
Change committed as 258363

Powered by Google App Engine
This is Rietveld 408576698