Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: src/isolate.cc

Issue 199583007: Reland "Throw exception on invalid string length instead of OOM." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: change Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/isolate.h ('k') | src/json-stringifier.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 933 matching lines...) Expand 10 before | Expand all | Expand 10 after
944 return Failure::Exception(); 944 return Failure::Exception();
945 } 945 }
946 946
947 947
948 Failure* Isolate::ThrowIllegalOperation() { 948 Failure* Isolate::ThrowIllegalOperation() {
949 if (FLAG_stack_trace_on_illegal) PrintStack(stdout); 949 if (FLAG_stack_trace_on_illegal) PrintStack(stdout);
950 return Throw(heap_.illegal_access_string()); 950 return Throw(heap_.illegal_access_string());
951 } 951 }
952 952
953 953
954 Failure* Isolate::ThrowInvalidStringLength() {
955 return Throw(*factory()->NewRangeError(
956 "invalid_string_length", HandleVector<Object>(NULL, 0)));
957 }
958
959
954 void Isolate::ScheduleThrow(Object* exception) { 960 void Isolate::ScheduleThrow(Object* exception) {
955 // When scheduling a throw we first throw the exception to get the 961 // When scheduling a throw we first throw the exception to get the
956 // error reporting if it is uncaught before rescheduling it. 962 // error reporting if it is uncaught before rescheduling it.
957 Throw(exception); 963 Throw(exception);
958 PropagatePendingExceptionToExternalTryCatch(); 964 PropagatePendingExceptionToExternalTryCatch();
959 if (has_pending_exception()) { 965 if (has_pending_exception()) {
960 thread_local_top()->scheduled_exception_ = pending_exception(); 966 thread_local_top()->scheduled_exception_ = pending_exception();
961 thread_local_top()->external_caught_exception_ = false; 967 thread_local_top()->external_caught_exception_ = false;
962 clear_pending_exception(); 968 clear_pending_exception();
963 } 969 }
(...skipping 1353 matching lines...) Expand 10 before | Expand all | Expand 10 after
2317 2323
2318 #ifdef DEBUG 2324 #ifdef DEBUG
2319 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \ 2325 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \
2320 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_); 2326 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_);
2321 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET) 2327 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET)
2322 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET) 2328 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET)
2323 #undef ISOLATE_FIELD_OFFSET 2329 #undef ISOLATE_FIELD_OFFSET
2324 #endif 2330 #endif
2325 2331
2326 } } // namespace v8::internal 2332 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/isolate.h ('k') | src/json-stringifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698