Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1995753003:
Cleanup some constexpr nits in base/numerics (Closed)
|
Created:
4 years, 7 months ago by jschuh Modified:
4 years, 7 months ago Reviewers:
brucedawson CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCleanup some constexpr nits in base/numerics
Cleanup some unneeded inlines and make two trivial cases constexpr
BUG=612995
Committed: https://crrev.com/5ae3e261c39b24073806b31c1701865fa4134842
Cr-Commit-Position: refs/heads/master@{#394680}
Patch Set 1 : nit #
Messages
Total messages: 25 (15 generated)
The CQ bit was checked by jschuh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995753003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
Description was changed from ========== constexpr all the easy things in base/numerics This is the first pass to cover the trivial cases. BUG=612995 ========== to ========== Cleanup some unneeded inline and make two trivial cases constexpr. BUG=612995 ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by jschuh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995753003/20001
brucedawson@chromium.org changed reviewers: + brucedawson@chromium.org
The issue title is missing from the description, which is potentially deceptive. Copy in the issue title plus a blank link to the beginning of the description? I guess the rule of thumb is that if you put constexpr in front of a function (or replace inline with constexpr) then if it compiles it is correct - I can't think of any times when that wouldn't be the case. So lgtm.
Description was changed from ========== Cleanup some unneeded inline and make two trivial cases constexpr. BUG=612995 ========== to ========== Cleanup some constexpr nits in base/numerics Cleanup some unneeded inlines and make two trivial cases constexpr BUG=612995 ==========
The CQ bit was unchecked by jschuh@chromium.org
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995753003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995753003/20001
The CQ bit was unchecked by jschuh@chromium.org
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995753003/20001
Message was sent while issue was closed.
Description was changed from ========== Cleanup some constexpr nits in base/numerics Cleanup some unneeded inlines and make two trivial cases constexpr BUG=612995 ========== to ========== Cleanup some constexpr nits in base/numerics Cleanup some unneeded inlines and make two trivial cases constexpr BUG=612995 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Cleanup some constexpr nits in base/numerics Cleanup some unneeded inlines and make two trivial cases constexpr BUG=612995 ========== to ========== Cleanup some constexpr nits in base/numerics Cleanup some unneeded inlines and make two trivial cases constexpr BUG=612995 Committed: https://crrev.com/5ae3e261c39b24073806b31c1701865fa4134842 Cr-Commit-Position: refs/heads/master@{#394680} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5ae3e261c39b24073806b31c1701865fa4134842 Cr-Commit-Position: refs/heads/master@{#394680} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
