Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1737)

Unified Diff: mojo/platform_handle/BUILD.gn

Issue 1995753002: [mojo-edk] Expose portable API for platform handle wrapping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/mojo_public.gyp ('k') | mojo/platform_handle/platform_handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/platform_handle/BUILD.gn
diff --git a/mojo/platform_handle/BUILD.gn b/mojo/platform_handle/BUILD.gn
index 16829abed233401ddc007705323e1d523ee5cc87..a3710c9200bfdfdd71e2d2b42b2dcaa1a4bcdc28 100644
--- a/mojo/platform_handle/BUILD.gn
+++ b/mojo/platform_handle/BUILD.gn
@@ -2,75 +2,16 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-# See comments in mojo/public/c/system/BUILD.gn which this is based on.
-# Summary: depend on this target to use the platform handle functions without
-# linking against a specific implementation.
-# For component targets, add //mojo/platform_handle:for_component to your deps
-# section.
-# For shared_library targets (e.g., a Mojo App), add
-# //mojo/platform_handle:for_shared_library to your deps.
-source_set("platform_handle") {
- sources = [
- "platform_handle.h",
- "platform_handle_functions.h",
- ]
- deps = [
- "//mojo/public/c/system",
- ]
-}
+# TODO(rockot): Remove this file. It's just a few dummy targets to avoid
+# updating lots of build files in the platform handle API change.
-component("platform_handle_impl") {
- output_name = "platform_handle_impl"
- public_deps = [
- ":platform_handle",
- ]
- sources = [
- "platform_handle_functions.cc",
- ]
- defines = [ "PLATFORM_HANDLE_IMPLEMENTATION" ]
- deps = [
- "//base",
- "//mojo/edk/embedder:headers",
- "//mojo/public/c/system:for_component",
- ]
+group("platform_handle") {
}
-
-source_set("platform_handle_thunks") {
- public_deps = [
- ":platform_handle",
- ]
- sources = [
- "platform_handle_private_thunks.cc",
- "platform_handle_private_thunks.h",
- ]
- defines = [ "PLATFORM_HANDLE_IMPLEMENTATION" ]
- deps = [
- "//mojo/public/c/system",
- ]
+group("platform_handle_impl") {
+}
+group("platform_handle_thunks") {
}
-
group("for_shared_library") {
- public_deps = [
- ":platform_handle",
- ]
- if (is_component_build) {
- deps = [
- ":platform_handle_impl",
- ]
- } else {
- deps = [
- ":platform_handle_thunks",
- ]
- }
}
-
group("for_component") {
- public_deps = [
- ":platform_handle",
- ]
- if (is_component_build) {
- deps = [
- ":platform_handle_impl",
- ]
- }
}
« no previous file with comments | « mojo/mojo_public.gyp ('k') | mojo/platform_handle/platform_handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698