Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 1995733005: Fix 2D canvas state persistency after OffscreenCanvas.transferToImageBitmap (Closed)

Created:
4 years, 7 months ago by Justin Novosad
Modified:
4 years, 6 months ago
CC:
chromium-reviews, ajuma+watch-canvas_chromium.org, dshwang, haraken, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 2D canvas state persistency after OffscreenCanvas.transferToImageBitmap This change restores the matrix and clip state stack on the new ImageBuffer that get created by OffscreenCanvasRenderingContext2D after the previous buffer was torn off by transferToImageBItmap. This change also adds the clip() method to OffscreenCanvasRenderingContext2D. BUG=593349 Committed: https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404 Cr-Commit-Position: refs/heads/master@{#396559}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase + test fix #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferToImageBitmap-state-persistency.html View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferToImageBitmap-state-persistency-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 1 chunk +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Justin Novosad
PTAL
4 years, 7 months ago (2016-05-19 21:24:48 UTC) #2
Stephen White
LGTM https://codereview.chromium.org/1995733005/diff/1/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl File third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl (right): https://codereview.chromium.org/1995733005/diff/1/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl#newcode33 third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl:33: void clip(Path2D path); Not sure I understand this ...
4 years, 7 months ago (2016-05-20 17:41:26 UTC) #3
Justin Novosad
On 2016/05/20 17:41:26, Stephen White wrote: > LGTM > > https://codereview.chromium.org/1995733005/diff/1/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl > File > third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl ...
4 years, 7 months ago (2016-05-20 17:44:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995733005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995733005/1
4 years, 7 months ago (2016-05-20 17:45:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/231679)
4 years, 7 months ago (2016-05-20 19:12:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995733005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995733005/20001
4 years, 6 months ago (2016-05-27 14:34:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/235172)
4 years, 6 months ago (2016-05-27 15:59:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995733005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995733005/40001
4 years, 6 months ago (2016-05-27 19:21:37 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-27 21:09:06 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 21:11:10 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404
Cr-Commit-Position: refs/heads/master@{#396559}

Powered by Google App Engine
This is Rietveld 408576698