Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1995733003: Forbid Oilpan GC in blink::testing::runPendingTasks (Closed)

Created:
4 years, 7 months ago by yhirano
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forbid Oilpan GC in blink::testing::runPendingTasks As webkit unittests are run outside of the message loop, tasks run in blink::testing::runPendingTasks are executed as non-nested tasks. That means the registered GCTaskObserver will run GC with NoHeapPointerOnStack. This is problematic because we often have heap pointers on stack. This change forbid Oilpan GC in runPendingTasks to avoid such a problem. BUG=613115 Committed: https://crrev.com/0b9fcb3822616d2e067aa29192f1d4e4238db2f9 Cr-Commit-Position: refs/heads/master@{#394743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yhirano
4 years, 7 months ago (2016-05-19 11:19:44 UTC) #2
haraken
LGTM, thanks.
4 years, 7 months ago (2016-05-19 11:25:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995733003/1
4 years, 7 months ago (2016-05-19 11:31:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 12:00:40 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 12:02:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b9fcb3822616d2e067aa29192f1d4e4238db2f9
Cr-Commit-Position: refs/heads/master@{#394743}

Powered by Google App Engine
This is Rietveld 408576698