Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 199573004: Remove unnecassary parameter "sampleRate" for loadAudioResource(). (Closed)

Created:
6 years, 9 months ago by KhNo
Modified:
6 years, 9 months ago
Reviewers:
jamesr, Raymond Toy
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove unnecassary parameter "sampleRate" for loadAudioResource(). Parameter "sampleRate" is not required for loadAudioResource(). There is FIXME in AudioBus.cpp in blink FIXME: the sampleRate parameter is ignored. It should be removed from the API. It will be consist of 3 steps. 1. Removing "sampleRate" in chrome which is called by blink. (included deprecated method) https://codereview.chromium.org/195043002/ 2. Removing "sampleRate" in blink. https://codereview.chromium.org/194753005/ 3. Removing deprecated method from #1 https://codereview.chromium.org/199573004/ BUG=351284 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
KhNo
Please review the patch :) Thanks.
6 years, 9 months ago (2014-03-14 01:21:39 UTC) #1
Raymond Toy
lgtm. Now would be a good time to try trybot, just for the experience.
6 years, 9 months ago (2014-03-14 03:27:39 UTC) #2
KhNo
On 2014/03/14 03:27:39, Raymond Toy wrote: > lgtm. > > Now would be a good ...
6 years, 9 months ago (2014-03-14 13:14:54 UTC) #3
Raymond Toy
On 2014/03/14 13:14:54, KhNo wrote: > On 2014/03/14 03:27:39, Raymond Toy wrote: > > lgtm. ...
6 years, 9 months ago (2014-03-14 16:23:51 UTC) #4
KhNo
On 2014/03/14 16:23:51, Raymond Toy wrote: > On 2014/03/14 13:14:54, KhNo wrote: > > On ...
6 years, 9 months ago (2014-03-15 04:48:45 UTC) #5
KhNo
@James Could I get LGTM?
6 years, 9 months ago (2014-03-16 10:22:19 UTC) #6
jamesr
lgtm
6 years, 9 months ago (2014-03-16 18:10:25 UTC) #7
KhNo
On 2014/03/16 18:10:25, jamesr wrote: > lgtm Thank you :)
6 years, 9 months ago (2014-03-17 02:33:15 UTC) #8
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 9 months ago (2014-03-18 02:31:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/199573004/1
6 years, 9 months ago (2014-03-18 03:21:46 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 03:35:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-18 03:35:16 UTC) #12
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 9 months ago (2014-03-18 05:09:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/199573004/1
6 years, 9 months ago (2014-03-18 05:09:59 UTC) #14
KhNo
The CQ bit was unchecked by keonho07.kim@samsung.com
6 years, 9 months ago (2014-03-18 12:49:10 UTC) #15
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 9 months ago (2014-03-18 12:49:12 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 18:43:05 UTC) #17
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-18 18:43:07 UTC) #18
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 9 months ago (2014-03-19 00:21:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/199573004/1
6 years, 9 months ago (2014-03-19 00:27:02 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 00:30:44 UTC) #21
Message was sent while issue was closed.
Change committed as 257830

Powered by Google App Engine
This is Rietveld 408576698