|
|
Created:
6 years, 9 months ago by KhNo Modified:
6 years, 9 months ago Reviewers:
jamesr, Raymond Toy CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionRemove unnecassary parameter "sampleRate" for loadAudioResource().
Parameter "sampleRate" is not required for loadAudioResource().
There is FIXME in AudioBus.cpp in blink
FIXME: the sampleRate parameter is ignored. It should be removed from
the API.
It will be consist of 3 steps.
1. Removing "sampleRate" in chrome which is called by blink. (included deprecated method)
https://codereview.chromium.org/195043002/
2. Removing "sampleRate" in blink.
https://codereview.chromium.org/194753005/
3. Removing deprecated method from #1
https://codereview.chromium.org/199573004/
BUG=351284
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257830
Patch Set 1 #
Created: 6 years, 9 months ago
Messages
Total messages: 21 (0 generated)
Please review the patch :) Thanks.
lgtm. Now would be a good time to try trybot, just for the experience.
On 2014/03/14 03:27:39, Raymond Toy wrote: > lgtm. > > Now would be a good time to try trybot, just for the experience. Thanks for lgtm. I have tried it. I guess I do not have permission of trybot. Test win, win_rel seems to be pending. "If you do not have an @chromium.org email address, or wish to use a different email address; Ask someone you're working with (a frequent reviewer, for example) to send email to committers@chromium.org nominating you for tryjob access. You must provide an email address and at least a brief explanation of why you'd like access. You can also ask for an @chromium.org address at this time." Congratulation! You are a frequent reviewer. :) Can I ask to you nominating me for try job access and @chromium.org ?
On 2014/03/14 13:14:54, KhNo wrote: > On 2014/03/14 03:27:39, Raymond Toy wrote: > > lgtm. > > > > Now would be a good time to try trybot, just for the experience. > > Thanks for lgtm. > I have tried it. I guess I do not have permission of trybot. Test win, win_rel > seems to be pending. > > > "If you do not have an @chromium.org email address, or wish to use a different > email address; > Ask someone you're working with (a frequent reviewer, for example) to send email > to mailto:committers@chromium.org nominating you for tryjob access. > You must provide an email address and at least a brief explanation of why you'd > like access. You can also ask for an @chromium.org address at this time." > > Congratulation! You are a frequent reviewer. :) > Can I ask to you nominating me for try job access and @chromium.org ? Do you want a chromium.org email address?
On 2014/03/14 16:23:51, Raymond Toy wrote: > On 2014/03/14 13:14:54, KhNo wrote: > > On 2014/03/14 03:27:39, Raymond Toy wrote: > > > lgtm. > > > > > > Now would be a good time to try trybot, just for the experience. > > > > Thanks for lgtm. > > I have tried it. I guess I do not have permission of trybot. Test win, win_rel > > seems to be pending. > > > > > > "If you do not have an @chromium.org email address, or wish to use a different > > email address; > > Ask someone you're working with (a frequent reviewer, for example) to send > email > > to mailto:committers@chromium.org nominating you for tryjob access. > > You must provide an email address and at least a brief explanation of why > you'd > > like access. You can also ask for an @chromium.org address at this time." > > > > Congratulation! You are a frequent reviewer. :) > > Can I ask to you nominating me for try job access and @chromium.org ? > > Do you want a http://chromium.org email address? If I can do myself something to request chromium.org for getting permission next time, Yes. I need. Actually, I do not want to bother you. :) If you are fine, I don't need email address now.
@James Could I get LGTM?
lgtm
On 2014/03/16 18:10:25, jamesr wrote: > lgtm Thank you :)
The CQ bit was checked by keonho07.kim@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/199573004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
The CQ bit was checked by keonho07.kim@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/199573004/1
The CQ bit was unchecked by keonho07.kim@samsung.com
The CQ bit was checked by keonho07.kim@samsung.com
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by keonho07.kim@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/199573004/1
Message was sent while issue was closed.
Change committed as 257830 |