Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1995723004: [test] add tests for async function stacktraces (Closed)

Created:
4 years, 7 months ago by caitp (gmail)
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] add tests for async function stacktraces BUG=v8:4483 R=littledan@chromium.org Committed: https://crrev.com/02f228eccdfcfab4081c2494ade52e54702b692c Cr-Commit-Position: refs/heads/master@{#36365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -0 lines) Patch
A test/mjsunit/harmony/async-function-stacktrace.js View 1 chunk +115 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
caitp (gmail)
stacktrace tests, revealing some bizarre FNI behaviours that I hope we can fix. Not having ...
4 years, 7 months ago (2016-05-18 22:36:15 UTC) #1
Dan Ehrenberg
lgtm These look like some good tests (to your comments, those cases actually seem fine ...
4 years, 7 months ago (2016-05-18 23:58:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995723004/1
4 years, 7 months ago (2016-05-19 13:13:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 13:27:39 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/02f228eccdfcfab4081c2494ade52e54702b692c Cr-Commit-Position: refs/heads/master@{#36365}
4 years, 7 months ago (2016-05-19 13:30:08 UTC) #7
Michael Achenbach
4 years, 7 months ago (2016-05-19 14:50:56 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1997453004/ by machenbach@chromium.org.

The reason for reverting is: Breaks gc stress:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/....

Powered by Google App Engine
This is Rietveld 408576698