Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: tools/dm_flags.py

Issue 1995703002: Blacklist HTC.dng on 32-bit Win CPU bots (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index baed46de2b1648a8c16400c6572b8a6806c6294a..737b78577853acf918123db779dcadbcf314aa5b 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -158,9 +158,13 @@ def get_args(bot):
blacklist.extend('_ image gen_platf 4bpp-pixeldata-cropped.bmp'.split(' '))
blacklist.extend('_ image gen_platf 32bpp-pixeldata-cropped.bmp'.split(' '))
blacklist.extend('_ image gen_platf 24bpp-pixeldata-cropped.bmp'.split(' '))
- if 'x86_64' in bot and 'CPU' in bot:
- # This GM triggers a SkSmallAllocator assert.
- blacklist.extend('_ gm _ composeshader_bitmap'.split(' '))
+ if 'CPU' in bot:
+ if 'x86_64' in bot:
+ # This GM triggers a SkSmallAllocator assert. skia:5315
+ blacklist.extend('_ gm _ composeshader_bitmap'.split(' '))
+ elif '-x86-' in bot:
+ # This image flakily fails to decode due to memory usage. skia:5318
+ blacklist.extend('_ image _ HTC.dng'.split(' '))
# skia:4095
for test in ['not_native32_bitmap_config',
@@ -277,6 +281,7 @@ def self_test():
'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN',
'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind',
'Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind',
+ 'Test-Win-MSVC-GCE-CPU-AVX2-x86-Release',
'Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug',
'Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan',
'Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Debug-ANGLE',
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698