Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: content/browser/browser_main_runner.cc

Issue 19957002: Run the later parts of startup as UI thread tasks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Run the later parts of startup as UI thread tasks - patch for Yaron's comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_main_runner.cc
diff --git a/content/browser/browser_main_runner.cc b/content/browser/browser_main_runner.cc
index f50832af1b73afd49bf1bc7d03e45cc2e87ae2b8..3f0964befa2aa12c2159f7bb35b91746da6975f6 100644
--- a/content/browser/browser_main_runner.cc
+++ b/content/browser/browser_main_runner.cc
@@ -40,8 +40,9 @@ class BrowserMainRunnerImpl : public BrowserMainRunner {
Shutdown();
}
- virtual int Initialize(const MainFunctionParams& parameters)
- OVERRIDE {
+ virtual int Initialize(
+ const MainFunctionParams& parameters,
+ const scoped_refptr<StartupTaskRunner>& task_runner) OVERRIDE {
Yaron 2013/07/25 00:05:17 Does this need to be a refptr? Couldn't ownership
aberent 2013/07/26 20:36:54 This has gone away due a restructuring following J
TRACE_EVENT0("startup", "BrowserMainRunnerImpl::Initialize")
is_initialized_ = true;
@@ -102,7 +103,7 @@ class BrowserMainRunnerImpl : public BrowserMainRunner {
#endif
ui::InitializeInputMethod();
- main_loop_->CreateThreads();
+ main_loop_->CreateStartupTasks(task_runner);
int result_code = main_loop_->GetResultCode();
if (result_code > 0)
return result_code;

Powered by Google App Engine
This is Rietveld 408576698