Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: content/browser/browser_main_loop.h

Issue 19957002: Run the later parts of startup as UI thread tasks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Run the later parts of startup as UI thread tasks - patch for Yaron's comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_main_loop.h
diff --git a/content/browser/browser_main_loop.h b/content/browser/browser_main_loop.h
index 0f3d3d711091cc463fcf7d1e3d1ddfc62b19b6ac..6502fbf3c8114fb29197f8a3b79c750c0537cb6e 100644
--- a/content/browser/browser_main_loop.h
+++ b/content/browser/browser_main_loop.h
@@ -6,8 +6,10 @@
#define CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_
#include "base/basictypes.h"
+#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "content/browser/browser_process_sub_thread.h"
+#include "content/public/common/startup_task_runner.h"
class CommandLine;
@@ -62,8 +64,8 @@ class CONTENT_EXPORT BrowserMainLoop {
void InitializeToolkit();
void MainMessageLoopStart();
- // Create all secondary threads.
- void CreateThreads();
+ // Create the tasks we need to complete startup.
+ void CreateStartupTasks(const scoped_refptr<StartupTaskRunner>& task_runner);
// Perform the default message loop run logic.
void RunMainMessageLoopParts();
@@ -91,9 +93,17 @@ class CONTENT_EXPORT BrowserMainLoop {
void InitializeMainThread();
+ // Called just before creating the threads
+ void PreCreateThreads();
+
+ // Create all secondary threads.
+ void CreateThreads();
+
// Called right after the browser threads have been started.
void BrowserThreadsStarted();
+ void PreMainMessageLoopRun();
+
void MainMessageLoopRun();
// Members initialized on construction ---------------------------------------

Powered by Google App Engine
This is Rietveld 408576698