Issue 1995663003: Revert of Introduce the Blink NotificationService, move permission checks there

Issue 1995663003: Revert of Introduce the Blink NotificationService, move permission checks there (Closed)

Created:
4 years, 7 months ago by Peter Beverloo

Modified:
4 years, 7 months ago

Reviewers:
esprehn, jam, dcheng, yzshen1, cmumford, Michael van Ouwerkerk, haraken

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, jam, mlamouri (slow - plz ping), nasko+codewatch_chromium.org, qsr+mojo_chromium.org, Sam McNally, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Introduce the Blink NotificationService, move permission checks there (patchset #8 id:130001 of https://codereview.chromium.org/1948223004/ ) Reason for revert: Causing crashes for users on Windows. Reverting. BUG=612770 Original issue's description: > Introduce the Blink NotificationService, move permission checks there > > This introduces the Mojo NotificationService in Blink and moves > permission checks over from the IPC code-path to the Mojo code-path. > > BUG=595685 > > Committed: https://crrev.com/c5987942de604fb5d51ef70e208931b713522955 > Cr-Commit-Position: refs/heads/master@{#394185} TBR=dcheng@chromium.org,cmumford@chromium.org,esprehn@chromium.org,haraken@chromium.org,jam@chromium.org,mvanouwerkerk@chromium.org,yzshen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595685 Committed: https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c Cr-Commit-Position: refs/heads/master@{#394473}

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -387 lines)			Patch
M	content/browser/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	content/browser/notifications/blink_notification_service_impl.h	View	1 chunk	+0 lines, -53 lines	0 comments	Download
D	content/browser/notifications/blink_notification_service_impl.cc	View	1 chunk	+0 lines, -71 lines	0 comments	Download
M	content/browser/notifications/notification_message_filter.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/notifications/notification_message_filter.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	content/browser/notifications/platform_notification_context_impl.h	View	5 chunks	+1 line, -26 lines	0 comments	Download
M	content/browser/notifications/platform_notification_context_impl.cc	View	3 chunks	+1 line, -41 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/child/notifications/notification_manager.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/child/notifications/notification_manager.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	content/common/platform_notification_messages.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/renderer/mojo/blink_service_registry_impl.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	content/renderer/mojo/blink_service_registry_impl.cc	View	1 chunk	+1 line, -13 lines	0 comments	Download
M	third_party/WebKit/Source/modules/modules.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/modules/notifications/Notification.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/notifications/Notification.cpp	View	4 chunks	+10 lines, -4 lines	0 comments	Download
D	third_party/WebKit/Source/modules/notifications/NotificationManager.h	View	1 chunk	+0 lines, -55 lines	0 comments	Download
D	third_party/WebKit/Source/modules/notifications/NotificationManager.cpp	View	1 chunk	+0 lines, -67 lines	0 comments	Download
M	third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/public/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/public/blink.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	third_party/WebKit/public/platform/modules/notifications/OWNERS	View	1 chunk	+1 line, -15 lines	0 comments	Download
M	third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
D	third_party/WebKit/public/platform/modules/notifications/notification_service.mojom	View	1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Peter Beverloo

Created Revert of Introduce the Blink NotificationService, move permission checks there

4 years, 7 months ago (2016-05-18 18:20:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995663003/1

4 years, 7 months ago (2016-05-18 18:20:56 UTC) #2

commit-bot: I haz the power

Description was changed from ========== Revert of Introduce the Blink NotificationService, move permission checks there ...

4 years, 7 months ago (2016-05-18 18:21:52 UTC) #3

commit-bot: I haz the power

Description was changed from ========== Revert of Introduce the Blink NotificationService, move permission checks there ...

4 years, 7 months ago (2016-05-18 18:23:14 UTC) #5

Message was sent while issue was closed.

Description was changed from

==========
Revert of Introduce the Blink NotificationService, move permission checks there
(patchset #8 id:130001 of https://codereview.chromium.org/1948223004/ )

Reason for revert:
Causing crashes for users on Windows. Reverting.

BUG=612770

Original issue's description:
> Introduce the Blink NotificationService, move permission checks there
> 
> This introduces the Mojo NotificationService in Blink and moves
> permission checks over from the IPC code-path to the Mojo code-path.
> 
> BUG=595685
> 
> Committed: https://crrev.com/c5987942de604fb5d51ef70e208931b713522955
> Cr-Commit-Position: refs/heads/master@{#394185}

TBR=dcheng@chromium.org,cmumford@chromium.org,esprehn@chromium.org,haraken@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595685
==========

to

==========
Revert of Introduce the Blink NotificationService, move permission checks there
(patchset #8 id:130001 of https://codereview.chromium.org/1948223004/ )

Reason for revert:
Causing crashes for users on Windows. Reverting.

BUG=612770

Original issue's description:
> Introduce the Blink NotificationService, move permission checks there
>
> This introduces the Mojo NotificationService in Blink and moves
> permission checks over from the IPC code-path to the Mojo code-path.
>
> BUG=595685
>
> Committed: https://crrev.com/c5987942de604fb5d51ef70e208931b713522955
> Cr-Commit-Position: refs/heads/master@{#394185}

TBR=dcheng@chromium.org,cmumford@chromium.org,esprehn@chromium.org,haraken@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595685

Committed: https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c
Cr-Commit-Position: refs/heads/master@{#394473}
==========

commit-bot: I haz the power

4 years, 7 months ago (2016-05-18 18:23:15 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c
Cr-Commit-Position: refs/heads/master@{#394473}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages