Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1995643002: Mojo C++ bindings: fail validation test if no test data found and add data dependency. (Closed)

Created:
4 years, 7 months ago by yzshen1
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: fail validation test if no test data found and add data dependency. BUG=604847 Committed: https://crrev.com/d8317fac5f89cb2d2b50be0632f8d5c52afa81c9 Cr-Commit-Position: refs/heads/master@{#394475}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M mojo/mojo_public_bindings_unittests.isolate View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
yzshen1
Hi, Ken. Please take a look. Thanks!
4 years, 7 months ago (2016-05-18 17:13:09 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-18 17:48:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995643002/20001
4 years, 7 months ago (2016-05-18 17:49:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 18:35:01 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 18:37:45 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8317fac5f89cb2d2b50be0632f8d5c52afa81c9
Cr-Commit-Position: refs/heads/master@{#394475}

Powered by Google App Engine
This is Rietveld 408576698