ui/views/widget/widget_unittest.cc - Issue 1995613003: views/mus: Fix some flaky crashes during test teardown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/widget_unittest.cc

Issue 1995613003: views/mus: Fix some flaky crashes during test teardown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@views-mus-more-focus-fix

Patch Set: . Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/widget_unittest.cc

diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc

index 10272acc51e4feac0b3ab73a5d177300260049fb..3dfd3572eb13c4c8a35543682d3651ba3ac60d6f 100644

--- a/ui/views/widget/widget_unittest.cc

+++ b/ui/views/widget/widget_unittest.cc

@@ -1952,8 +1952,9 @@ TEST_F(WidgetTest, WidgetDeleted_InOnMousePressed) {

#if !defined(OS_MACOSX) || defined(USE_AURA)

TEST_F(WidgetTest, WidgetDeleted_InDispatchGestureEvent) {

- // This test doesn't make sense for mus. Force NativeWidgetAura to be used.

- DisableNativeWidgetMus();

+ // This test doesn't make sense for mus.

+ if (IsMus())

+ return;

Widget* widget = new Widget;

Widget::InitParams params =

« no previous file with comments | « ui/views/test/views_test_base.cc ('k') | no next file » | no next file with comments »