Issue 19956004: Flush parallel recompilation queues on context dispose notification.

Issue 19956004: Flush parallel recompilation queues on context dispose notification. (Closed)

Created:
7 years, 5 months ago by Yang

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Flush parallel recompilation queues on context dispose notification. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15833

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -50 lines)			Patch
M	src/api.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/factory.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/heap.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	src/heap.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/isolate.h	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	src/isolate.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/liveedit.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	src/optimizing-compiler-thread.h	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	src/optimizing-compiler-thread.cc	View	1	3 chunks	+51 lines, -15 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/test-deoptimization.cc	View		6 chunks	+13 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://codereview.chromium.org/19956004/diff/1/src/optimizing-compiler-thread.cc File src/optimizing-compiler-thread.cc (right): https://codereview.chromium.org/19956004/diff/1/src/optimizing-compiler-thread.cc#newcode134 src/optimizing-compiler-thread.cc:134: printf("flush!\n"); debugging leftover?

7 years, 5 months ago (2013-07-23 14:27:54 UTC) #2

Yang

https://codereview.chromium.org/19956004/diff/1/src/optimizing-compiler-thread.cc File src/optimizing-compiler-thread.cc (right): https://codereview.chromium.org/19956004/diff/1/src/optimizing-compiler-thread.cc#newcode134 src/optimizing-compiler-thread.cc:134: printf("flush!\n"); On 2013/07/23 14:27:54, Jakob wrote: > debugging leftover? ...

7 years, 5 months ago (2013-07-23 15:05:25 UTC) #3

Yang

7 years, 5 months ago (2013-07-23 15:15:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15833 (presubmit successful).

Expand Messages | Collapse Messages