third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt - Issue 1995583002: Throw exception for non-finite values in setValueCurve

Unified Diff: third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt

Issue 1995583002: Throw exception for non-finite values in setValueCurve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return nullptr instead Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions.html ('k') | third_party/WebKit/Source/modules/webaudio/AudioParam.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AudioParam.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt

diff --git a/third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt b/third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt

index dc44e6ba07fe9ff5020c75947153b30eb479650e..2d2564a71cf15c48dbd999e9c60bebb93e4c9fc5 100644

--- a/third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt

+++ b/third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt

@@ -19,9 +19,14 @@ PASS setValueCurveAtTime(curve, 0.00625, 0.01) threw NotSupportedError: Failed t

PASS setValueCurveAtTime(curve, 0.018750000000000003, 0.01) threw NotSupportedError: Failed to execute 'setValueCurveAtTime' on 'AudioParam': setValueCurveAtTime(..., 0.01875, 0.01) overlaps exponentialRampToValue(1, 0.025).

PASS setValueCurveAtTime(curve, 0.03125, 0.01) threw NotSupportedError: Failed to execute 'setValueCurveAtTime' on 'AudioParam': setValueCurveAtTime(..., 0.03125, 0.01) overlaps setTargetAtTime(1, 0.03750000000000001, 0.1).

PASS setValueCurveAtTime(curve, 0.043750000000000004, 0.01) threw NotSupportedError: Failed to execute 'setValueCurveAtTime' on 'AudioParam': setValueCurveAtTime(..., 0.04375, 0.01) overlaps setValueCurveAtTime(..., 0.05, 0.1).

+PASS setValueCurveAtTime([NaN, NaN], 0.043750000000000004, 0.01) threw TypeError: Failed to execute 'setValueCurveAtTime' on 'AudioParam': The provided float value for the curve at element 0 is non-finite: NaN.

+PASS setValueCurveAtTime([1, Infinity], 0.043750000000000004, 0.01) threw TypeError: Failed to execute 'setValueCurveAtTime' on 'AudioParam': The provided float value for the curve at element 1 is non-finite: Infinity.

PASS setValueCurveAtTime(curve, 0.031415926535897934, 0.01) threw NotSupportedError: Failed to execute 'setValueCurveAtTime' on 'AudioParam': setValueCurveAtTime(..., 0.03141592653589793, 0.01) overlaps setTargetAtTime(1, 0.03750000000000001, 0.1).

PASS setValueCurve overlapping existing automation functions correctly signaled errors.

+PASS Handled setValueCurve exception so output contains only the constant 1.

+PASS setValueCurveAtTime correctly not inserted into timeline.

PASS setValueAtTime(1, 0) did not throw an exception.

PASS linearRampToValueAtTime(0, 0.0025) did not throw an exception.

PASS setValueCurveAtTime(..., 0.0025, 0.0025) did not throw an exception.