Throw exception for non-finite values in setValueCurve

third_party/WebKit/Source/modules/webaudio/AudioParam.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
  *     documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
  * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
  * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "modules/webaudio/AudioParam.h"
 
+#include "core/dom/ExceptionCode.h"
 #include "core/inspector/ConsoleMessage.h"
 #include "modules/webaudio/AudioNode.h"
 #include "modules/webaudio/AudioNodeOutput.h"
 #include "platform/FloatConversion.h"
 #include "platform/Histogram.h"
 #include "platform/audio/AudioUtilities.h"
 #include "platform/v8_inspector/public/ConsoleTypes.h"
 #include "wtf/MathExtras.h"
 
 namespace blink {
@@ skipping 409 matching lines @@
     warnIfOutsideRange("setTargetAtTime value", target);
     handler().timeline().setTargetAtTime(target, time, timeConstant, exceptionState);
 
     // Don't update the histogram here.  It's not clear in normal usage if the parameter value will
     // actually reach |target|.
     return this;
 }
 
 AudioParam* AudioParam::setValueCurveAtTime(DOMFloat32Array* curve, double time, double duration, ExceptionState& exceptionState)
 {
-    // Just find the first value in the curve (if any) that is outside the nominal range.  It's
-    // probably not necessary to produce a warning on every value outside the nominal range.
     float* curveData = curve->data();
     float min = minValue();
     float max = maxValue();
 
+    // First, find any non-finite value in the curve and throw an exception if
+    // there are any.
     for (unsigned k = 0; k < curve->length(); ++k) {
-        if (curveData[k] < min || curveData[k] > max) {
-            warnIfOutsideRange("setValueCurveAtTime value", curveData[k]);
+        float value = curveData[k];
+
+        if (!std::isfinite(value)) {
+            exceptionState.throwDOMException(
+                V8TypeError,
+                "The provided float value for the curve at element "
+                + String::number(k)
+                + " is non-finite: "
+                + String::number(value));
+            return nullptr;
+        }
+    }
+
+    // Second, find the first value in the curve (if any) that is outside the
+    // nominal range.  It's probably not necessary to produce a warning on every
+    // value outside the nominal range.
+    for (unsigned k = 0; k < curve->length(); ++k) {
+        float value = curveData[k];
+
+        if (value < min || value > max) {
+            warnIfOutsideRange("setValueCurveAtTime value", value);
             break;
         }
     }
 
     handler().timeline().setValueCurveAtTime(curve, time, duration, exceptionState);
 
     // We could update the histogram with every value in the curve, due to interpolation, we'll
     // probably be missing many values.  So we don't update the histogram.  setValueCurveAtTime is
     // probably a fairly rare method anyway.
     return this;
 }
 
 AudioParam* AudioParam::cancelScheduledValues(double startTime, ExceptionState& exceptionState)
 {
     handler().timeline().cancelScheduledValues(startTime, exceptionState);
     return this;
 }
 
 } // namespace blink