Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: content/renderer/media/webrtc/processed_local_audio_source.cc

Issue 1995553002: Remove WebRtc audio source references for local audio tracks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert unintentional change Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc/processed_local_audio_source.cc
diff --git a/content/renderer/media/webrtc/processed_local_audio_source.cc b/content/renderer/media/webrtc/processed_local_audio_source.cc
index 8ae1fed64be8fa3251d9d82bd990281a7272f4e1..b25469372a3625d563595da73736689b78ec2e44 100644
--- a/content/renderer/media/webrtc/processed_local_audio_source.cc
+++ b/content/renderer/media/webrtc/processed_local_audio_source.cc
@@ -105,31 +105,6 @@ bool ProcessedLocalAudioSource::EnsureSourceIsStarted() {
return false;
}
- // Build an AudioOptions by applying relevant constraints to it, and then use
- // it to create a webrtc::AudioSourceInterface instance.
- cricket::AudioOptions rtc_options;
- rtc_options.echo_cancellation = ConstraintToOptional(
- constraints_, &blink::WebMediaTrackConstraintSet::echoCancellation);
- rtc_options.delay_agnostic_aec = ConstraintToOptional(
- constraints_, &blink::WebMediaTrackConstraintSet::googDAEchoCancellation);
- rtc_options.auto_gain_control = ConstraintToOptional(
- constraints_, &blink::WebMediaTrackConstraintSet::googAutoGainControl);
- rtc_options.experimental_agc = ConstraintToOptional(
- constraints_,
- &blink::WebMediaTrackConstraintSet::googExperimentalAutoGainControl);
- rtc_options.noise_suppression = ConstraintToOptional(
- constraints_, &blink::WebMediaTrackConstraintSet::googNoiseSuppression);
- rtc_options.experimental_ns = ConstraintToOptional(
- constraints_,
- &blink::WebMediaTrackConstraintSet::googExperimentalNoiseSuppression);
- rtc_options.highpass_filter = ConstraintToOptional(
- constraints_, &blink::WebMediaTrackConstraintSet::googHighpassFilter);
- rtc_options.typing_detection = ConstraintToOptional(
- constraints_,
- &blink::WebMediaTrackConstraintSet::googTypingNoiseDetection);
- rtc_options.stereo_swapping = ConstraintToOptional(
- constraints_, &blink::WebMediaTrackConstraintSet::googAudioMirroring);
- MediaAudioConstraints::ApplyFixedAudioConstraints(&rtc_options);
if (device_info().device.input.effects &
media::AudioParameters::ECHO_CANCELLER) {
// TODO(hta): Figure out if we should be looking at echoCancellation.
@@ -142,13 +117,6 @@ bool ProcessedLocalAudioSource::EnsureSourceIsStarted() {
~media::AudioParameters::ECHO_CANCELLER;
SetDeviceInfo(modified_device_info);
}
- rtc_options.echo_cancellation = rtc::Optional<bool>(false);
- }
- rtc_source_ = pc_factory_->CreateLocalAudioSource(rtc_options);
- if (rtc_source_->state() != webrtc::MediaSourceInterface::kLive) {
- WebRtcLogMessage("ProcessedLocalAudioSource::EnsureSourceIsStarted() fails "
- " because the rtc LocalAudioSource is not live.");
- return false;
}
// Create the MediaStreamAudioProcessor, bound to the WebRTC audio device

Powered by Google App Engine
This is Rietveld 408576698