Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1995553002: Remove WebRtc audio source references for local audio tracks. (Closed)

Created:
4 years, 7 months ago by tommi (sloooow) - chröme
Modified:
4 years, 7 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebRtc audio source references for local audio tracks. Remove PeerConnectionDependencyFactory::CreateLocalAudioSource. Remove audio source mock class that's not needed now. BUG=612809, 612366 Committed: https://crrev.com/fcfeb8bc42fa37a8875480a0581372c496a303f0 Cr-Commit-Position: refs/heads/master@{#394575}

Patch Set 1 #

Patch Set 2 : Fix initialization of WebRtcAudioDeviceImpl to always be on the same thread #

Patch Set 3 : Revert unintentional change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -120 lines) Patch
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h View 3 chunks +0 lines, -23 lines 0 comments Download
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 5 chunks +5 lines, -10 lines 0 comments Download
M content/renderer/media/webrtc/processed_local_audio_source.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/media/webrtc/processed_local_audio_source.cc View 1 2 2 chunks +0 lines, -32 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_media_stream_adapter.cc View 2 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
tommi (sloooow) - chröme
4 years, 7 months ago (2016-05-18 13:53:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995553002/1
4 years, 7 months ago (2016-05-18 13:53:53 UTC) #4
perkj_chrome
lgtm
4 years, 7 months ago (2016-05-18 14:08:58 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/113360)
4 years, 7 months ago (2016-05-18 14:24:52 UTC) #8
tommi (sloooow) - chröme
Fix initialization of WebRtcAudioDeviceImpl to always be on the same thread
4 years, 7 months ago (2016-05-18 20:22:45 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995553002/20001
4 years, 7 months ago (2016-05-18 20:23:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995553002/20001
4 years, 7 months ago (2016-05-18 20:37:27 UTC) #16
tommi (sloooow) - chröme
Revert unintentional change
4 years, 7 months ago (2016-05-18 20:42:22 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995553002/40001
4 years, 7 months ago (2016-05-18 20:43:59 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/113683)
4 years, 7 months ago (2016-05-18 21:22:48 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995553002/40001
4 years, 7 months ago (2016-05-18 21:38:10 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-18 22:25:49 UTC) #27
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 22:28:05 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fcfeb8bc42fa37a8875480a0581372c496a303f0
Cr-Commit-Position: refs/heads/master@{#394575}

Powered by Google App Engine
This is Rietveld 408576698