Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: testing_support/gerrit-init.sh

Issue 199553002: Emergency fix to avoid gerrit 2.9 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing_support/gerrit-init.sh
diff --git a/testing_support/gerrit-init.sh b/testing_support/gerrit-init.sh
index a969f98b5e5889de5b46b8f9554f73b043c4a7cb..4884a3cb2e0950f7ddc70934a4b4e6de2aa35172 100755
--- a/testing_support/gerrit-init.sh
+++ b/testing_support/gerrit-init.sh
@@ -77,10 +77,16 @@ import re
import sys
requested_version = sys.argv[1] if len(sys.argv) > 1 else None
-gerrit_re = re.compile('gerrit(?:-full)?-([0-9.]+)(-rc[0-9]+)?[.]war')
+# Disable using -rc versions. This is a temporary hack to avoid
+# picking up version 2.9-rc0, which requires java 7. These lines
+# should be un-commented after this bug is fixed:
+# https://code.google.com/p/chromium/issues/detail?id=346369
+#gerrit_re = re.compile('gerrit(?:-full)?-([0-9.]+)(-rc[0-9]+)?[.]war')
+gerrit_re = re.compile('gerrit(?:-full)?-([0-9.]+)[.]war')
j = json.load(sys.stdin)
items = [(x, gerrit_re.match(x['name'])) for x in j['items']]
-items = [(x, m.group(1), m.group(2)) for x, m in items if m]
+#items = [(x, m.group(1), m.group(2)) for x, m in items if m]
+items = [(x, m.group(1), '') for x, m in items if m]
def _cmp(a, b):
an = a[1].split('.')
bn = b[1].split('.')
@@ -88,12 +94,8 @@ def _cmp(a, b):
an.append('0')
while len(bn) < len(an):
bn.append('0')
-# Disable using -rc versions. This is a temporary hack to avoid
-# picking up version 2.9-rc0, which requires java 7. These lines
-# should be un-commented after this bug is fixed:
-# https://code.google.com/p/chromium/issues/detail?id=346369
-# an.append(a[2][3:] if a[2] else '1000')
-# bn.append(b[2][3:] if b[2] else '1000')
+ an.append(a[2][3:] if a[2] else '1000')
+ bn.append(b[2][3:] if b[2] else '1000')
for i in range(len(an)):
if an[i] != bn[i]:
return -1 if int(an[i]) > int(bn[i]) else 1
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698