Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1995483002: [arm][arm64] Remove COHERENT_CACHE support (Closed)

Created:
4 years, 7 months ago by Jakob Kummerow
Modified:
4 years, 7 months ago
Reviewers:
Yang, Michael Hablich
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm][arm64] Remove COHERENT_CACHE support We have evidence (see r34896) that this avoids crashes. BUG=chromium:524337 Committed: https://crrev.com/e83ac2342d69ba51f966028d23d4865da3116755 Cr-Commit-Position: refs/heads/master@{#36317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -40 lines) Patch
M src/arm/assembler-arm.cc View 2 chunks +8 lines, -21 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +4 lines, -17 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/globals.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jakob Kummerow
PTAL.
4 years, 7 months ago (2016-05-18 10:11:38 UTC) #2
Michael Hablich
On 2016/05/18 10:11:38, Jakob wrote: > PTAL. rubberstamp lgtm; code should probably be lgtm by ...
4 years, 7 months ago (2016-05-18 10:14:21 UTC) #3
Yang
On 2016/05/18 10:14:21, Hablich wrote: > On 2016/05/18 10:11:38, Jakob wrote: > > PTAL. > ...
4 years, 7 months ago (2016-05-18 10:33:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995483002/1
4 years, 7 months ago (2016-05-18 10:33:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 11:06:39 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 11:09:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e83ac2342d69ba51f966028d23d4865da3116755
Cr-Commit-Position: refs/heads/master@{#36317}

Powered by Google App Engine
This is Rietveld 408576698