Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1995473002: Fix MIPS64 compilation issue with GN build system (Closed)

Created:
4 years, 7 months ago by ivica.bogosavljevic
Modified:
4 years, 7 months ago
Reviewers:
gordana.cmiljanovic, alph, Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix MIPS64 compilation issue with GN build system NOTRY=true Committed: https://crrev.com/4a96bc2a947e17a7bb55bc5174a73ab290c91b46 Cr-Commit-Position: refs/heads/master@{#36328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ivica.bogosavljevic
4 years, 7 months ago (2016-05-18 08:53:10 UTC) #3
Michael Achenbach
lgtm
4 years, 7 months ago (2016-05-18 14:40:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995473002/1
4 years, 7 months ago (2016-05-18 14:40:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 14:42:28 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 14:44:44 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4a96bc2a947e17a7bb55bc5174a73ab290c91b46
Cr-Commit-Position: refs/heads/master@{#36328}

Powered by Google App Engine
This is Rietveld 408576698