chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java - Issue 1995433003: Adding elevation to NTP snippets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java

Issue 1995433003: Adding elevation to NTP snippets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values/dimens.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java

index d02da31db0c8709350fc90e55a5329403dc4c5ee..4979f868d5b8406192058a8256d0a098d6902ed1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java

@@ -175,12 +175,10 @@ public class NewTabPageLayout extends LinearLayout {

private void setSearchBoxStyle() {

if ((ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_SNIPPETS)

|| ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_MATERIAL_DESIGN))

- && ApiCompatibilityUtils.isElevationSupported()) {

+ && ApiCompatibilityUtils.setElevation(mSearchBoxView,

+ getResources().getDimensionPixelSize(R.dimen.toolbar_elevation))) {

// Replace drawable with one that does not contain a border.

mSearchBoxView.setBackgroundResource(R.drawable.bg_ntp_search_box_material);

- // Add an elevation to the search box.

- mSearchBoxView.setElevation(

- getResources().getDimensionPixelSize(R.dimen.toolbar_elevation));

}