Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 1995403002: cc: Update effect_tree backface visibility when transform is updated. (Closed)

Created:
4 years, 7 months ago by ajuma
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

cc: Update effect_tree backface visibility when transform is updated. We should update effect_tree as well in UpdatePropertyTrees when an animation cause a change in transform tree. Failing to update it may cause draw_property_utils incorrectly skip layers. This CL forces the update and added a related unit test. BUG=610280 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1994213002 Cr-Commit-Position: refs/heads/master@{#394846} (cherry picked from commit 59dd7daef0b5f11d6f8dd6dd5141967ab0deb0b4) Committed: https://chromium.googlesource.com/chromium/src/+/7e784d1b8f8de4627f6075050ad52e7ca735512c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -2 lines) Patch
M cc/trees/draw_property_utils.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ajuma
4 years, 7 months ago (2016-05-20 20:08:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e784d1b8f8de4627f6075050ad52e7ca735512c.

Powered by Google App Engine
This is Rietveld 408576698