Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1995393002: Domain Reliability: Add a few more Google domains. (Closed)

Created:
4 years, 7 months ago by Julia Tuttle
Modified:
4 years, 7 months ago
Reviewers:
cbentzel, davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Domain Reliability: Add a few more Google domains. BUG=613648 Committed: https://crrev.com/62bfd35632dadeee692658c8eef6fa375d760b20 Cr-Commit-Position: refs/heads/master@{#395122}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M components/domain_reliability/google_configs.cc View 3 chunks +18 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
Julia Tuttle
PTAL, cbentzel or davidben.
4 years, 7 months ago (2016-05-20 16:24:08 UTC) #2
davidben
lgtm
4 years, 7 months ago (2016-05-20 17:40:45 UTC) #3
cbentzel
https://codereview.chromium.org/1995393002/diff/1/components/domain_reliability/google_configs.cc File components/domain_reliability/google_configs.cc (right): https://codereview.chromium.org/1995393002/diff/1/components/domain_reliability/google_configs.cc#newcode321 components/domain_reliability/google_configs.cc:321: { "google.stackdriver.com", true, false, false }, Is this redundant ...
4 years, 7 months ago (2016-05-20 17:40:46 UTC) #4
cbentzel
On 2016/05/20 17:40:46, cbentzel wrote: > https://codereview.chromium.org/1995393002/diff/1/components/domain_reliability/google_configs.cc > File components/domain_reliability/google_configs.cc (right): > > https://codereview.chromium.org/1995393002/diff/1/components/domain_reliability/google_configs.cc#newcode321 > ...
4 years, 7 months ago (2016-05-20 18:23:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995393002/1
4 years, 7 months ago (2016-05-20 18:28:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 18:32:39 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 18:34:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62bfd35632dadeee692658c8eef6fa375d760b20
Cr-Commit-Position: refs/heads/master@{#395122}

Powered by Google App Engine
This is Rietveld 408576698