Domain Reliability: Add a few more Google domains.

Domain Reliability: Add a few more Google domains.

BUG=613648
Committed: https://crrev.com/62bfd35632dadeee692658c8eef6fa375d760b20
Cr-Commit-Position: refs/heads/master@{#395122}

[Julia Tuttle, 2016-05-20 16:24:08]

juliatuttle@chromium.org changed reviewers:
+ cbentzel@chromium.org, davidben@chromium.org

[Julia Tuttle, 2016-05-20 16:24:08]

PTAL, cbentzel or davidben.

[davidben, 2016-05-20 17:40:45]

lgtm

[cbentzel, 2016-05-20 17:40:46]

https://codereview.chromium.org/1995393002/diff/1/components/domain_reliabili...
File components/domain_reliability/google_configs.cc (right):

https://codereview.chromium.org/1995393002/diff/1/components/domain_reliabili...
components/domain_reliability/google_configs.cc:321: { "google.stackdriver.com",
true, false, false },
Is this redundant with the stackdriver.com inclusion below, which has
includeSubdomains?

Ditto for every other new gstatic.com subdomain listed, as gstatic.com included
here.

[cbentzel, 2016-05-20 18:23:41]

On 2016/05/20 17:40:46, cbentzel wrote:
>
https://codereview.chromium.org/1995393002/diff/1/components/domain_reliabili...
> File components/domain_reliability/google_configs.cc (right):
> 
>
https://codereview.chromium.org/1995393002/diff/1/components/domain_reliabili...
> components/domain_reliability/google_configs.cc:321: {
"google.stackdriver.com",
> true, false, false },
> Is this redundant with the http://stackdriver.com inclusion below, which has
> includeSubdomains?
> 
> Ditto for every other new http://gstatic.com subdomain listed, as
http://gstatic.com included
> here.

Sounds like includeSubdomains only handles one additional label and not the
entire subtree under the specified namespace.

I'll admit that this is a bit strange to me, but doesn't need to change for this
CL.

Can you associate a bug with this change?

Otherwise, LGTM

[Julia Tuttle, 2016-05-20 18:27:27]

Description was changed from

==========
Domain Reliability: Add a few more Google domains.

BUG=
==========

to

==========
Domain Reliability: Add a few more Google domains.

BUG=613648
==========

[Julia Tuttle, 2016-05-20 18:28:18]

The CQ bit was checked by juliatuttle@chromium.org

[commit-bot: I haz the power, 2016-05-20 18:28:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995393002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995393002/1

[commit-bot: I haz the power, 2016-05-20 18:32:38]

Description was changed from

==========
Domain Reliability: Add a few more Google domains.

BUG=613648
==========

to

==========
Domain Reliability: Add a few more Google domains.

BUG=613648
==========

[commit-bot: I haz the power, 2016-05-20 18:32:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-20 18:34:19]

Description was changed from

==========
Domain Reliability: Add a few more Google domains.

BUG=613648
==========

to

==========
Domain Reliability: Add a few more Google domains.

BUG=613648

Committed: https://crrev.com/62bfd35632dadeee692658c8eef6fa375d760b20
Cr-Commit-Position: refs/heads/master@{#395122}
==========

[commit-bot: I haz the power, 2016-05-20 18:34:20]

Patchset 1 (id:??) landed as
https://crrev.com/62bfd35632dadeee692658c8eef6fa375d760b20
Cr-Commit-Position: refs/heads/master@{#395122}