third_party/WebKit/Source/core/editing/InputMethodController.h - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add 3 tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/input_messages.h ('K') | « content/renderer/render_widget.cc ('k') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/InputMethodController.h

diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.h b/third_party/WebKit/Source/core/editing/InputMethodController.h

index 2a36cd448c04744b1a4cd951af5f87b778700fef..6267ae601545473a82ccd932357cd1615ec26b68 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodController.h

+++ b/third_party/WebKit/Source/core/editing/InputMethodController.h

@@ -65,7 +65,7 @@ public:

bool confirmComposition(const String& text, ConfirmCompositionBehavior confirmBehavior = KeepSelection);

// Inserts the text that is being composed or specified non-empty text and

// returns true.

- bool confirmCompositionOrInsertText(const String& text, ConfirmCompositionBehavior);

+ bool confirmCompositionOrInsertText(const String& text, ConfirmCompositionBehavior, int newCursorPosition);

// Deletes the existing composition text.

void cancelComposition();

void cancelCompositionIfSelectionIsInvalid();