Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: content/renderer/render_widget.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: For aelias and yosin review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index 793016a7459bc8f907f199ebcaf223752a3f272e..34d9ee0c5499e5cffe4e579963e27cdd333c89c6 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -489,9 +489,11 @@ class CONTENT_EXPORT RenderWidget
const gfx::Range& replacement_range,
int selection_start,
int selection_end);
- virtual void OnImeConfirmComposition(const base::string16& text,
- const gfx::Range& replacement_range,
- bool keep_selection);
+ virtual void OnImeCommitText(const base::string16& text,
+ const gfx::Range& replacement_range,
+ int relative_cursor_pos);
+ virtual void OnImeFinishComposingText(bool keep_selection);
+
// Called when the device scale factor is changed, or the layer tree is
// initialized.
virtual void OnDeviceScaleFactorChanged();

Powered by Google App Engine
This is Rietveld 408576698