Chromium Code Reviews

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: For aelias and yosin review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 4f1cc5ad0966ee5390155039648bf3af8eed83ec..39e1154c9ee9a836bd64d23c8263d6fe836030d3 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -1418,12 +1418,15 @@ void RenderWidgetHostImpl::ImeSetComposition(
selection_start, selection_end));
}
-void RenderWidgetHostImpl::ImeConfirmComposition(
- const base::string16& text,
- const gfx::Range& replacement_range,
- bool keep_selection) {
- Send(new InputMsg_ImeConfirmComposition(
- GetRoutingID(), text, replacement_range, keep_selection));
+void RenderWidgetHostImpl::ImeCommitText(const base::string16& text,
+ const gfx::Range& replacement_range,
+ int relative_cursor_pos) {
+ Send(new InputMsg_ImeCommitText(GetRoutingID(), text, replacement_range,
+ relative_cursor_pos));
+}
+
+void RenderWidgetHostImpl::ImeFinishComposingText(bool keep_selection) {
+ Send(new InputMsg_ImeFinishComposingText(GetRoutingID(), keep_selection));
}
void RenderWidgetHostImpl::ImeCancelComposition() {

Powered by Google App Engine