third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Split confirmComposition into 2 Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/InputMethodController.cpp ('K') | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 31c14587f437d0987d640e9e2786b59f517133d9..cc772df45f1fdffba51ec2171fe9978885120183 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -943,19 +943,6 @@ void WebLocalFrameImpl::replaceSelection(const WebString& text)

frame()->editor().replaceSelectionWithText(text, selectReplacement, smartReplace);

}

-void WebLocalFrameImpl::insertText(const WebString& text)

- if (frame()->inputMethodController().hasComposition()) {

- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets

- // needs to be audited. See http://crbug.com/590369 for more details.

- frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();

- frame()->inputMethodController().confirmComposition(text);

- } else {

- frame()->editor().insertText(text, 0);

- }

void WebLocalFrameImpl::setMarkedText(const WebString& text, unsigned location, unsigned length)

{

Vector<CompositionUnderline> decorations;