Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: content/renderer/render_frame_impl.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split confirmComposition into 2 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 44277066d87c04c54ea536d548440609cf65a618..e0f94229fbf40e1fc6ea202f19ad0e2db235eaa5 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -356,8 +356,9 @@ class CONTENT_EXPORT RenderFrameImpl
const std::vector<blink::WebCompositionUnderline>& underlines,
int selection_start,
int selection_end);
- void SimulateImeConfirmComposition(const base::string16& text,
- const gfx::Range& replacement_range);
+ void SimulateImeCommitText(const base::string16& text,
+ const gfx::Range& replacement_range);
+ void SimulateImeFinishComposingText(bool keep_selection);
// TODO(jam): remove these once the IPC handler moves from RenderView to
// RenderFrame.
@@ -366,9 +367,11 @@ class CONTENT_EXPORT RenderFrameImpl
const std::vector<blink::WebCompositionUnderline>& underlines,
int selection_start,
int selection_end);
- void OnImeConfirmComposition(const base::string16& text,
- const gfx::Range& replacement_range,
- bool keep_selection);
+ void OnImeCommitText(const base::string16& text,
+ const gfx::Range& replacement_range,
+ int relative_cursor_pos);
+ void OnImeFinishComposingText(bool keep_selection);
+
#endif // defined(ENABLE_PLUGINS)
// May return NULL in some cases, especially if userMediaClient() returns

Powered by Google App Engine
This is Rietveld 408576698