Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: third_party/WebKit/public/web/WebWidget.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move caret within composing text. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebWidget.h
diff --git a/third_party/WebKit/public/web/WebWidget.h b/third_party/WebKit/public/web/WebWidget.h
index fa3c4fab267f362e56a6e28ebf5a7e6cbe5b5d96..4a200bdf8a67659bd6c9de25d8b15a54c4b7456d 100644
--- a/third_party/WebKit/public/web/WebWidget.h
+++ b/third_party/WebKit/public/web/WebWidget.h
@@ -162,10 +162,12 @@ public:
// Called to inform the WebWidget to confirm an ongoing composition with a
// new composition text. If the text is empty then the current composition
// text is confirmed. If there is no ongoing composition, then deletes the
- // current selection and inserts the text. This method has no effect if
+ // current selection and inserts the text. This method will change the
+ // selection according to relativeCaretPosition, which is relative to the
+ // end of the composing or inserting text.This method has no effect if
// there is no ongoing composition and the text is empty.
// Returns true if there is an ongoing composition or the text is inserted.
- virtual bool confirmComposition(const WebString& text) { return false; }
+ virtual bool confirmComposition(const WebString& text, int relativeCaretPosition) { return false; }
// Fetches the character range of the current composition, also called the
// "marked range." Returns true and fills the out-paramters on success;

Powered by Google App Engine
This is Rietveld 408576698