content/browser/renderer_host/render_widget_host_impl.h - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move caret within composing text. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/ime_adapter_android.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_impl.h

diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h

index 0999abfc8dc50bec67d819bb1e98e68d061448e7..878686ee9b48668e3bd6bc8c3ea343ee8df539df 100644

--- a/content/browser/renderer_host/render_widget_host_impl.h

+++ b/content/browser/renderer_host/render_widget_host_impl.h

@@ -376,7 +376,8 @@ class CONTENT_EXPORT RenderWidgetHostImpl : public RenderWidgetHost,

// * when insertText of NSTextInput is called (on Mac).

void ImeConfirmComposition(const base::string16& text,

const gfx::Range& replacement_range,

- bool keep_selection);

+ bool keep_selection,

+ int relative_cursor_pos = 0);

aelias_OOO_until_Jul13 2016/09/01 05:21:58 Default argument values are against Chromium style

yabinh 2016/09/06 11:25:54 Done.

// Cancels an ongoing composition.

void ImeCancelComposition();