Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: content/browser/renderer_host/ime_adapter_android.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move caret within composing text. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/ime_adapter_android.h
diff --git a/content/browser/renderer_host/ime_adapter_android.h b/content/browser/renderer_host/ime_adapter_android.h
index f181dfa45c2f7db6da562f2a1c9e94d19ba248f2..1c4c45915efba4db5abb72386eb83371cca0b551 100644
--- a/content/browser/renderer_host/ime_adapter_android.h
+++ b/content/browser/renderer_host/ime_adapter_android.h
@@ -46,10 +46,11 @@ class ImeAdapterAndroid {
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jobject>& text,
const base::android::JavaParamRef<jstring>& text_str,
- int new_cursor_pos);
+ int relative_cursor_pos);
void CommitText(JNIEnv*,
const base::android::JavaParamRef<jobject>&,
- const base::android::JavaParamRef<jstring>& text_str);
+ const base::android::JavaParamRef<jstring>& text_str,
+ int relative_cursor_pos);
void FinishComposingText(JNIEnv* env,
const base::android::JavaParamRef<jobject>&);
void AttachImeAdapter(

Powered by Google App Engine
This is Rietveld 408576698