content/renderer/render_frame_impl.cc - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjust selection in confirmCompositionOrInsertText() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 1386b37783ecbea77602dfb670b435f43e1f6032..7aceee1be7a81297deeb3356c1ac34fe8789a1d2 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -1363,7 +1363,7 @@ void RenderFrameImpl::SimulateImeSetComposition(

void RenderFrameImpl::SimulateImeConfirmComposition(

const base::string16& text,

const gfx::Range& replacement_range) {

- render_view_->OnImeConfirmComposition(text, replacement_range, false);

+ render_view_->OnImeConfirmComposition(text, replacement_range, false, 1);

}

void RenderFrameImpl::OnImeSetComposition(

@@ -1400,7 +1400,8 @@ void RenderFrameImpl::OnImeSetComposition(

void RenderFrameImpl::OnImeConfirmComposition(

const base::string16& text,

const gfx::Range& replacement_range,

- bool keep_selection) {

+ bool keep_selection,

+ int newCursorPosition) {

Changwan Ryu 2016/08/03 07:37:30 new_cursor_position

yabinh 2016/08/08 07:33:43 Done.

// When a PPAPI plugin has focus, we bypass WebKit.

// Here, text.empty() has a special meaning. It means to commit the last

// update of composition text (see

« content/renderer/render_frame_impl.h ('K') | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_browsertest.cc » ('j') | content/renderer/render_widget.cc » ('J')