Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: For yosin@'s 2nd review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index 99092e4ba99f2a870b097f51a661c7778080d6f5..a7e6fb01f0f4ccb9517c69968f58004b74241ef8 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -120,7 +120,8 @@ class CONTENT_EXPORT BrowserPlugin :
int selectionEnd) override;
bool confirmComposition(
const blink::WebString& text,
- blink::WebWidget::ConfirmCompositionBehavior selectionBehavior) override;
+ blink::WebWidget::ConfirmCompositionBehavior selection_behavior,
+ int relative_cursor_pos) override;
void extendSelectionAndDelete(int before, int after) override;
// MouseLockDispatcher::LockTarget implementation.

Powered by Google App Engine
This is Rietveld 408576698