content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: For yosin@'s 2nd review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/input_messages.h ('k') | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

index e40bdd0b50bf6cf74f35ba0c33804d178a619683..12a42b6ce29084078dbba6232de6697496314c32 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

@@ -566,7 +566,7 @@ public class ImeAdapter {

timestampMs, COMPOSITION_KEY_CODE, 0, false, unicodeFromKeyEvent);

if (isCommit) {

- nativeCommitText(mNativeImeAdapterAndroid, text.toString());

+ nativeCommitText(mNativeImeAdapterAndroid, text.toString(), newCursorPosition);

} else {

nativeSetComposingText(

mNativeImeAdapterAndroid, text, text.toString(), newCursorPosition);

@@ -768,7 +768,8 @@ public class ImeAdapter {

int end, int backgroundColor);

private native void nativeSetComposingText(long nativeImeAdapterAndroid, CharSequence text,

String textStr, int newCursorPosition);

- private native void nativeCommitText(long nativeImeAdapterAndroid, String textStr);

+ private native void nativeCommitText(

+ long nativeImeAdapterAndroid, String textStr, int newCursorPosition);

private native void nativeFinishComposingText(long nativeImeAdapterAndroid);

private native void nativeAttachImeAdapter(long nativeImeAdapterAndroid);

private native void nativeSetEditableSelectionOffsets(long nativeImeAdapterAndroid,