components/test_runner/text_input_controller.cc - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/text_input_controller.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: For yosin@'s 2nd review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/text_input_controller.cc

diff --git a/components/test_runner/text_input_controller.cc b/components/test_runner/text_input_controller.cc

index cd0aa73b8f394b3e6d7c1649e954ae49c103fd5f..28c4fe41f6d06d054fa9c4835727c1afd50b43cc 100644

--- a/components/test_runner/text_input_controller.cc

+++ b/components/test_runner/text_input_controller.cc

@@ -160,7 +160,7 @@ void TextInputController::Install(blink::WebLocalFrame* frame) {

}

void TextInputController::InsertText(const std::string& text) {

- view()->confirmComposition(blink::WebString::fromUTF8(text));

+ view()->confirmComposition(blink::WebString::fromUTF8(text), 1);

}

void TextInputController::UnmarkText() {

« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('J')