third_party/WebKit/public/web/WebPlugin.h - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebPlugin.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: For compile error. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/InputMethodController.cpp ('K') | « third_party/WebKit/public/web/WebLocalFrame.h ('k') | third_party/WebKit/public/web/WebWidget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/WebPlugin.h

diff --git a/third_party/WebKit/public/web/WebPlugin.h b/third_party/WebKit/public/web/WebPlugin.h

index 9e9d71dbc271534ffd13ba50adef7f8df765e489..a9c271ee255706fe46b6729c59885426d7e59f53 100644

--- a/third_party/WebKit/public/web/WebPlugin.h

+++ b/third_party/WebKit/public/web/WebPlugin.h

@@ -156,7 +156,7 @@ public:

virtual bool setComposition(const WebString& text, const WebVector<WebCompositionUnderline>& underlines, int selectionStart, int selectionEnd) { return false; }

// Confirms an ongoing composition and returns true if there is an ongoing

// composition or the text is inserted.

- virtual bool confirmComposition(const WebString& text, WebWidget::ConfirmCompositionBehavior selectionBehavior) { return false; }

+ virtual bool confirmComposition(const WebString& text, WebWidget::ConfirmCompositionBehavior selectionBehavior, int relativeCursorPosition) { return false; }

yosin_UTC9 2016/08/26 10:06:11 Could you use "caret" instead of "cursor" in Blink

yabinh 2016/08/29 05:49:53 Done.

// Deletes the current selection plus the specified number of characters

// before and after the selection or caret.

virtual void extendSelectionAndDelete(int before, int after) { }