Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Unified Diff: third_party/WebKit/public/web/WebWidget.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebWidget.h
diff --git a/third_party/WebKit/public/web/WebWidget.h b/third_party/WebKit/public/web/WebWidget.h
index 1c064044c87376ca1494203c69669a5d83c9bfb6..bbfeba4216c795925a246b77361aaeb5260a0d2f 100644
--- a/third_party/WebKit/public/web/WebWidget.h
+++ b/third_party/WebKit/public/web/WebWidget.h
@@ -156,8 +156,8 @@ public:
// Called to inform the WebWidget to confirm an ongoing composition.
// This method is same as confirmComposition(WebString());
// Returns true if there is an ongoing composition.
- virtual bool confirmComposition() { return false; } // Deprecated
- virtual bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) { return false; }
+ virtual bool confirmComposition(int newCursorPosition = 1) { return false; } // Deprecated
+ virtual bool confirmComposition(ConfirmCompositionBehavior selectionBehavior, int newCursorPosition = 1) { return false; }
// Called to inform the WebWidget to confirm an ongoing composition with a
// new composition text. If the text is empty then the current composition
@@ -165,7 +165,7 @@ public:
// current selection and inserts the text. This method has no effect if
// there is no ongoing composition and the text is empty.
// Returns true if there is an ongoing composition or the text is inserted.
- virtual bool confirmComposition(const WebString& text) { return false; }
+ virtual bool confirmComposition(const WebString& text, int newCursorPosition = 1) { return false; }
// Fetches the character range of the current composition, also called the
// "marked range." Returns true and fills the out-paramters on success;
« third_party/WebKit/Source/web/WebViewImpl.cpp ('K') | « third_party/WebKit/public/web/WebPlugin.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698