Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: third_party/WebKit/Source/web/WebViewFrameWidget.cpp

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewFrameWidget.cpp
diff --git a/third_party/WebKit/Source/web/WebViewFrameWidget.cpp b/third_party/WebKit/Source/web/WebViewFrameWidget.cpp
index 0ed5769c41589233b8ee0aae4c00fe23446254e3..a7ce054781047420a2f2eedb8df4a5c85c4b43ad 100644
--- a/third_party/WebKit/Source/web/WebViewFrameWidget.cpp
+++ b/third_party/WebKit/Source/web/WebViewFrameWidget.cpp
@@ -135,19 +135,19 @@ bool WebViewFrameWidget::setComposition(
return m_webView->setComposition(text, underlines, selectionStart, selectionEnd);
}
-bool WebViewFrameWidget::confirmComposition()
+bool WebViewFrameWidget::confirmComposition(int newCursorPosition)
{
- return m_webView->confirmComposition();
+ return m_webView->confirmComposition(newCursorPosition);
}
-bool WebViewFrameWidget::confirmComposition(ConfirmCompositionBehavior selectionBehavior)
+bool WebViewFrameWidget::confirmComposition(ConfirmCompositionBehavior selectionBehavior, int newCursorPosition)
{
- return m_webView->confirmComposition(selectionBehavior);
+ return m_webView->confirmComposition(selectionBehavior, newCursorPosition);
}
-bool WebViewFrameWidget::confirmComposition(const WebString& text)
+bool WebViewFrameWidget::confirmComposition(const WebString& text, int newCursorPosition)
{
- return m_webView->confirmComposition(text);
+ return m_webView->confirmComposition(text, newCursorPosition);
}
bool WebViewFrameWidget::compositionRange(size_t* location, size_t* length)

Powered by Google App Engine
This is Rietveld 408576698