Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: content/renderer/render_view_impl.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 71c52a3638a8ae77d8aab5cd8af10cf0ab98892f..3dc242dd7dea48938de2dbe500d9eea698579b9d 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2860,12 +2860,13 @@ void RenderViewImpl::OnImeSetComposition(
void RenderViewImpl::OnImeConfirmComposition(
const base::string16& text,
const gfx::Range& replacement_range,
- bool keep_selection) {
+ bool keep_selection,
+ int newCursorPosition) {
#if defined(ENABLE_PLUGINS)
PepperPluginInstanceImpl* focused_pepper_plugin = GetFocusedPepperPlugin();
if (focused_pepper_plugin) {
focused_pepper_plugin->render_frame()->OnImeConfirmComposition(
- text, replacement_range, keep_selection);
+ text, replacement_range, keep_selection, newCursorPosition);
return;
}
#endif // ENABLE_PLUGINS
@@ -2881,7 +2882,8 @@ void RenderViewImpl::OnImeConfirmComposition(
}
RenderWidget::OnImeConfirmComposition(text,
replacement_range,
- keep_selection);
+ keep_selection,
+ newCursorPosition);
}
void RenderViewImpl::RenderWidgetDidSetColorProfile(

Powered by Google App Engine
This is Rietveld 408576698