content/renderer/browser_plugin/browser_plugin.cc - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.h ('k') | content/renderer/render_frame_impl.h » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin.cc

diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc

index 3731f8e833be2091a9f9ca69a279ec617b817079..71ceef4236626b0b821c628f79a9c303d5550229 100644

--- a/content/renderer/browser_plugin/browser_plugin.cc

+++ b/content/renderer/browser_plugin/browser_plugin.cc

@@ -531,7 +531,8 @@ bool BrowserPlugin::setComposition(

bool BrowserPlugin::confirmComposition(

const blink::WebString& text,

- blink::WebWidget::ConfirmCompositionBehavior selectionBehavior) {

+ blink::WebWidget::ConfirmCompositionBehavior selectionBehavior,

+ int newCursorPosition) {

if (!attached())

return false;

bool keep_selection = (selectionBehavior == blink::WebWidget::KeepSelection);

@@ -539,7 +540,8 @@ bool BrowserPlugin::confirmComposition(

new BrowserPluginHostMsg_ImeConfirmComposition(

browser_plugin_instance_id_,

text.utf8(),

- keep_selection));

+ keep_selection,

+ newCursorPosition));

// TODO(kochi): This assumes the IPC handling always succeeds.

return true;

}