content/browser/browser_plugin/browser_plugin_guest.cc - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.h ('k') | content/browser/renderer_host/ime_adapter_android.h » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index 71e285717171346f5b8915eea590170182ddcd59..feb5b7b81cb4544a588fd45141ca1a72d773637f 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -852,14 +852,15 @@ void BrowserPluginGuest::OnImeSetComposition(

selection_start, selection_end));

}

-void BrowserPluginGuest::OnImeConfirmComposition(

- int browser_plugin_instance_id,

- const std::string& text,

- bool keep_selection) {

+void BrowserPluginGuest::OnImeConfirmComposition(int browser_plugin_instance_id,

+ const std::string& text,

+ bool keep_selection,

+ int newCursorPosition) {

Send(new InputMsg_ImeConfirmComposition(routing_id(),

base::UTF8ToUTF16(text),

gfx::Range::InvalidRange(),

- keep_selection));

+ keep_selection,

+ newCursorPosition));

}

void BrowserPluginGuest::OnExtendSelectionAndDelete(