Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add 3 tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 float topControlsShownRatioDelta) override; 136 float topControlsShownRatioDelta) override;
137 void mouseCaptureLost() override; 137 void mouseCaptureLost() override;
138 void setFocus(bool enable) override; 138 void setFocus(bool enable) override;
139 bool setComposition( 139 bool setComposition(
140 const WebString& text, 140 const WebString& text,
141 const WebVector<WebCompositionUnderline>& underlines, 141 const WebVector<WebCompositionUnderline>& underlines,
142 int selectionStart, 142 int selectionStart,
143 int selectionEnd) override; 143 int selectionEnd) override;
144 bool confirmComposition() override; 144 bool confirmComposition() override;
145 bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) overri de; 145 bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) overri de;
146 bool confirmComposition(const WebString& text) override; 146 bool confirmComposition(const WebString& text, int newCursorPosition) overri de;
147 bool compositionRange(size_t* location, size_t* length) override; 147 bool compositionRange(size_t* location, size_t* length) override;
148 WebTextInputInfo textInputInfo() override; 148 WebTextInputInfo textInputInfo() override;
149 WebTextInputType textInputType() override; 149 WebTextInputType textInputType() override;
150 WebColor backgroundColor() const override; 150 WebColor backgroundColor() const override;
151 WebPagePopup* pagePopup() const override; 151 WebPagePopup* pagePopup() const override;
152 bool selectionBounds(WebRect& anchor, WebRect& focus) const override; 152 bool selectionBounds(WebRect& anchor, WebRect& focus) const override;
153 bool selectionTextDirection(WebTextDirection& start, WebTextDirection& end) const override; 153 bool selectionTextDirection(WebTextDirection& start, WebTextDirection& end) const override;
154 bool isSelectionAnchorFirst() const override; 154 bool isSelectionAnchorFirst() const override;
155 bool caretOrSelectionRange(size_t* location, size_t* length) override; 155 bool caretOrSelectionRange(size_t* location, size_t* length) override;
156 void setTextDirection(WebTextDirection) override; 156 void setTextDirection(WebTextDirection) override;
(...skipping 400 matching lines...) Expand 10 before | Expand all | Expand 10 after
557 explicit WebViewImpl(WebViewClient*, WebPageVisibilityState); 557 explicit WebViewImpl(WebViewClient*, WebPageVisibilityState);
558 ~WebViewImpl() override; 558 ~WebViewImpl() override;
559 559
560 int textInputFlags(); 560 int textInputFlags();
561 561
562 WebString inputModeOfFocusedElement(); 562 WebString inputModeOfFocusedElement();
563 563
564 // Returns true if the event was actually processed. 564 // Returns true if the event was actually processed.
565 bool keyEventDefault(const WebKeyboardEvent&); 565 bool keyEventDefault(const WebKeyboardEvent&);
566 566
567 bool confirmComposition(const WebString& text, ConfirmCompositionBehavior); 567 bool confirmComposition(const WebString& text, ConfirmCompositionBehavior, i nt newCursorPosition);
568 568
569 // Returns true if the view was scrolled. 569 // Returns true if the view was scrolled.
570 bool scrollViewWithKeyboard(int keyCode, int modifiers); 570 bool scrollViewWithKeyboard(int keyCode, int modifiers);
571 571
572 void hideSelectPopup(); 572 void hideSelectPopup();
573 573
574 HitTestResult hitTestResultForRootFramePos(const IntPoint&); 574 HitTestResult hitTestResultForRootFramePos(const IntPoint&);
575 HitTestResult hitTestResultForViewportPos(const IntPoint&); 575 HitTestResult hitTestResultForViewportPos(const IntPoint&);
576 576
577 // Consolidate some common code between starting a drag over a target and 577 // Consolidate some common code between starting a drag over a target and
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
780 Persistent<ResizeViewportAnchor> m_resizeViewportAnchor; 780 Persistent<ResizeViewportAnchor> m_resizeViewportAnchor;
781 }; 781 };
782 782
783 // We have no ways to check if the specified WebView is an instance of 783 // We have no ways to check if the specified WebView is an instance of
784 // WebViewImpl because WebViewImpl is the only implementation of WebView. 784 // WebViewImpl because WebViewImpl is the only implementation of WebView.
785 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 785 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
786 786
787 } // namespace blink 787 } // namespace blink
788 788
789 #endif 789 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698