content/browser/renderer_host/ime_adapter_android.h - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Side by Side Diff: content/browser/renderer_host/ime_adapter_android.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync. Almost the same to the previous patch. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/renderer_host/ime_adapter_android.cc » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_	5 #ifndef CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_

6 #define CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_	6 #define CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_

7	7

8 #include <jni.h>	8 #include <jni.h>

9	9

10 #include <vector>	10 #include <vector>

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 int scan_code,	42 int scan_code,

43 bool is_system_key,	43 bool is_system_key,

44 int unicode_text);	44 int unicode_text);

45 void SetComposingText(JNIEnv*,	45 void SetComposingText(JNIEnv*,

46 const base::android::JavaParamRef<jobject>& obj,	46 const base::android::JavaParamRef<jobject>& obj,

47 const base::android::JavaParamRef<jobject>& text,	47 const base::android::JavaParamRef<jobject>& text,

48 const base::android::JavaParamRef<jstring>& text_str,	48 const base::android::JavaParamRef<jstring>& text_str,

49 int new_cursor_pos);	49 int new_cursor_pos);

50 void CommitText(JNIEnv*,	50 void CommitText(JNIEnv*,

51 const base::android::JavaParamRef<jobject>&,	51 const base::android::JavaParamRef<jobject>&,

52 const base::android::JavaParamRef<jstring>& text_str);	52 const base::android::JavaParamRef<jstring>& text_str,

	53 int new_cursor_pos = 1);
	Changwan Ryu 2016/08/24 01:32:03 this is probably not needed? this is probably not needed? yabinh 2016/08/24 06:05:01 Done. Show quoted text On 2016/08/24 01:32:03, Changwan Ryu wrote: > this is probably not needed? Done.
53 void FinishComposingText(JNIEnv* env,	54 void FinishComposingText(JNIEnv* env,

54 const base::android::JavaParamRef<jobject>&);	55 const base::android::JavaParamRef<jobject>&);

55 void AttachImeAdapter(	56 void AttachImeAdapter(

56 JNIEnv*,	57 JNIEnv*,

57 const base::android::JavaParamRef<jobject>& java_object);	58 const base::android::JavaParamRef<jobject>& java_object);

58 void SetEditableSelectionOffsets(JNIEnv*,	59 void SetEditableSelectionOffsets(JNIEnv*,

59 const base::android::JavaParamRef<jobject>&,	60 const base::android::JavaParamRef<jobject>&,

60 int start,	61 int start,

61 int end);	62 int end);

62 void SetComposingRegion(JNIEnv*,	63 void SetComposingRegion(JNIEnv*,

(...skipping 23 matching lines...) Expand all Loading...
86	87

87 RenderWidgetHostViewAndroid* rwhva_;	88 RenderWidgetHostViewAndroid* rwhva_;

88 JavaObjectWeakGlobalRef java_ime_adapter_;	89 JavaObjectWeakGlobalRef java_ime_adapter_;

89 };	90 };

90	91

91 bool RegisterImeAdapter(JNIEnv* env);	92 bool RegisterImeAdapter(JNIEnv* env);

92	93

93 } // namespace content	94 } // namespace content

94	95

95 #endif // CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_	96 #endif // CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_

OLD	NEW