Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adjust selection in confirmCompositionOrInsertText() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 void setComposition(const String&, const Vector<CompositionUnderline>&, int selectionStart, int selectionEnd); 57 void setComposition(const String&, const Vector<CompositionUnderline>&, int selectionStart, int selectionEnd);
58 void setCompositionFromExistingText(const Vector<CompositionUnderline>&, uns igned compositionStart, unsigned compositionEnd); 58 void setCompositionFromExistingText(const Vector<CompositionUnderline>&, uns igned compositionStart, unsigned compositionEnd);
59 // Inserts the text that is being composed as a regular text and returns tru e 59 // Inserts the text that is being composed as a regular text and returns tru e
60 // if composition exists. 60 // if composition exists.
61 bool confirmComposition(); 61 bool confirmComposition();
62 // Inserts the given text string in the place of the existing composition 62 // Inserts the given text string in the place of the existing composition
63 // and returns true. 63 // and returns true.
64 bool confirmComposition(const String& text, ConfirmCompositionBehavior confi rmBehavior = KeepSelection); 64 bool confirmComposition(const String& text, ConfirmCompositionBehavior confi rmBehavior = KeepSelection);
65 // Inserts the text that is being composed or specified non-empty text and 65 // Inserts the text that is being composed or specified non-empty text and
66 // returns true. 66 // returns true.
67 bool confirmCompositionOrInsertText(const String& text, ConfirmCompositionBe havior); 67 bool confirmCompositionOrInsertText(const String& text, ConfirmCompositionBe havior, int newCursorPosition);
68 // Deletes the existing composition text. 68 // Deletes the existing composition text.
69 void cancelComposition(); 69 void cancelComposition();
70 void cancelCompositionIfSelectionIsInvalid(); 70 void cancelCompositionIfSelectionIsInvalid();
71 EphemeralRange compositionEphemeralRange() const; 71 EphemeralRange compositionEphemeralRange() const;
72 Range* compositionRange() const; 72 Range* compositionRange() const;
73 73
74 void clear(); 74 void clear();
75 void documentDetached(); 75 void documentDetached();
76 76
77 PlainTextRange getSelectionOffsets() const; 77 PlainTextRange getSelectionOffsets() const;
(...skipping 30 matching lines...) Expand all
108 } 108 }
109 109
110 String composingText() const; 110 String composingText() const;
111 void selectComposition() const; 111 void selectComposition() const;
112 bool setSelectionOffsets(const PlainTextRange&); 112 bool setSelectionOffsets(const PlainTextRange&);
113 }; 113 };
114 114
115 } // namespace blink 115 } // namespace blink
116 116
117 #endif // InputMethodController_h 117 #endif // InputMethodController_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698