Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adjust selection in confirmCompositionOrInsertText() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 int selection_end); 363 int selection_end);
364 364
365 // Finishes an ongoing composition with the specified text. 365 // Finishes an ongoing composition with the specified text.
366 // A browser should call this function: 366 // A browser should call this function:
367 // * when it receives a WM_IME_COMPOSITION message with a GCS_RESULTSTR flag 367 // * when it receives a WM_IME_COMPOSITION message with a GCS_RESULTSTR flag
368 // (on Windows); 368 // (on Windows);
369 // * when it receives a "commit" signal of GtkIMContext (on Linux); 369 // * when it receives a "commit" signal of GtkIMContext (on Linux);
370 // * when insertText of NSTextInput is called (on Mac). 370 // * when insertText of NSTextInput is called (on Mac).
371 void ImeConfirmComposition(const base::string16& text, 371 void ImeConfirmComposition(const base::string16& text,
372 const gfx::Range& replacement_range, 372 const gfx::Range& replacement_range,
373 bool keep_selection); 373 bool keep_selection,
374 int new_cursor_pos = 1);
374 375
375 // Cancels an ongoing composition. 376 // Cancels an ongoing composition.
376 void ImeCancelComposition(); 377 void ImeCancelComposition();
377 378
378 bool ignore_input_events() const { 379 bool ignore_input_events() const {
379 return ignore_input_events_; 380 return ignore_input_events_;
380 } 381 }
381 382
382 // Whether forwarded WebInputEvents should be dropped. 383 // Whether forwarded WebInputEvents should be dropped.
383 bool ShouldDropInputEvents() const; 384 bool ShouldDropInputEvents() const;
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
827 #endif 828 #endif
828 829
829 base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_; 830 base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_;
830 831
831 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl); 832 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);
832 }; 833 };
833 834
834 } // namespace content 835 } // namespace content
835 836
836 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 837 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698