Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: content/browser/renderer_host/ime_adapter_android.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adjust selection in confirmCompositionOrInsertText() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 int native_key_code, 52 int native_key_code,
53 int modifiers, 53 int modifiers,
54 int unicode_char); 54 int unicode_char);
55 void SetComposingText(JNIEnv*, 55 void SetComposingText(JNIEnv*,
56 const base::android::JavaParamRef<jobject>& obj, 56 const base::android::JavaParamRef<jobject>& obj,
57 const base::android::JavaParamRef<jobject>& text, 57 const base::android::JavaParamRef<jobject>& text,
58 const base::android::JavaParamRef<jstring>& text_str, 58 const base::android::JavaParamRef<jstring>& text_str,
59 int new_cursor_pos); 59 int new_cursor_pos);
60 void CommitText(JNIEnv*, 60 void CommitText(JNIEnv*,
61 const base::android::JavaParamRef<jobject>&, 61 const base::android::JavaParamRef<jobject>&,
62 const base::android::JavaParamRef<jstring>& text_str); 62 const base::android::JavaParamRef<jstring>& text_str,
63 int new_cursor_pos = 1);
63 void FinishComposingText(JNIEnv* env, 64 void FinishComposingText(JNIEnv* env,
64 const base::android::JavaParamRef<jobject>&); 65 const base::android::JavaParamRef<jobject>&);
65 void AttachImeAdapter( 66 void AttachImeAdapter(
66 JNIEnv*, 67 JNIEnv*,
67 const base::android::JavaParamRef<jobject>& java_object); 68 const base::android::JavaParamRef<jobject>& java_object);
68 void SetEditableSelectionOffsets(JNIEnv*, 69 void SetEditableSelectionOffsets(JNIEnv*,
69 const base::android::JavaParamRef<jobject>&, 70 const base::android::JavaParamRef<jobject>&,
70 int start, 71 int start,
71 int end); 72 int end);
72 void SetComposingRegion(JNIEnv*, 73 void SetComposingRegion(JNIEnv*,
(...skipping 23 matching lines...) Expand all
96 97
97 RenderWidgetHostViewAndroid* rwhva_; 98 RenderWidgetHostViewAndroid* rwhva_;
98 JavaObjectWeakGlobalRef java_ime_adapter_; 99 JavaObjectWeakGlobalRef java_ime_adapter_;
99 }; 100 };
100 101
101 bool RegisterImeAdapter(JNIEnv* env); 102 bool RegisterImeAdapter(JNIEnv* env);
102 103
103 } // namespace content 104 } // namespace content
104 105
105 #endif // CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_ 106 #endif // CONTENT_BROWSER_RENDERER_HOST_IME_ADAPTER_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698